Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

ci: Check if components folder exists befor trying to tar it #443

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

lukasholzer
Copy link
Contributor

Pull Request

Currently, the build fails when the build stage doesn't build the components library. In case there is no dist folder with components that can be packed.

So we have to pack it only when the folder exists.

Fixes #420

@lukasholzer lukasholzer added pr: needs-rebase This PR needs rebasing pr: wip labels Jan 16, 2020
@lukasholzer lukasholzer self-assigned this Jan 16, 2020
@lukasholzer lukasholzer force-pushed the ci./fix-failing-store-artifacts branch from 2595ec3 to 451d8a9 Compare January 16, 2020 08:38
@lukasholzer lukasholzer removed pr: needs-rebase This PR needs rebasing pr: wip labels Jan 16, 2020
@lukasholzer lukasholzer marked this pull request as ready for review January 16, 2020 08:38
@lukasholzer lukasholzer added bug A broken behaviour that was working previously P1 Urgent issue that should be resolved before the next release labels Jan 16, 2020
@lukasholzer lukasholzer added this to the Open source milestone Jan 16, 2020
ffriedl89
ffriedl89 previously approved these changes Jan 16, 2020
Copy link
Collaborator

@ffriedl89 ffriedl89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomheller
tomheller previously approved these changes Jan 17, 2020
Currently, the build fails when the build stage doesn't build the components library.
In case there is no dist folder with components that can be packed.
So we have to pack it only when the folder exists.

Fixes #420
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lukasholzer lukasholzer merged commit 89ef65c into master Jan 17, 2020
@lukasholzer lukasholzer deleted the ci./fix-failing-store-artifacts branch January 17, 2020 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A broken behaviour that was working previously P1 Urgent issue that should be resolved before the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: Artefact creation fails if no components have been affected
3 participants