This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update Codeowners for releasing. #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasholzer
requested review from
ffriedl89,
thomaspink and
tomheller
as code owners
tomheller
suggested changes
Jan 17, 2020
.github/CODEOWNERS
Outdated
| @@ -100,7 +100,7 @@ | |||
| /tools/linting/* @thomaspink @lukasholzer | |||
| /tools/linting/src/** @rowa-audil @lara-aigmueller @heartdisease | |||
|
|
|||
| /tools/release/** @thomaspink | |||
| /tools/release/** @lukasholzer | |||
There was a problem hiding this comment.
please add at least a second person. Having only one owner is potentially blocking us from moving forward and will bottleneck and silo us.
There was a problem hiding this comment.
good point will add @ffriedl89 who did the refactoring
lukasholzer
force-pushed
the
chore/update-codeowners
branch
from
b42a6ac
to
fdd1e60
Compare
tomheller
approved these changes
Jan 17, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Hi, thank you for contributing to Barista with this pull request (PR).
To ensure a fast process and merging of your PR please make sure it fulfills the
coding standards and contribution guidelines.
often helpful).
guidelines.
Please choose the type appropriate for the changes below:
Type of PR
Other
Checklist