Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

feat(empty-state): Allow custom empty-states #549

Merged
merged 1 commit into from
Feb 13, 2020
Merged

feat(empty-state): Allow custom empty-states #549

merged 1 commit into from
Feb 13, 2020

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Feb 5, 2020

Enables the usage of custom empty states. This in turn makes empty states reusable.

Closes #528

Pull Request

Type of PR

Feature

Checklist

  • I have read the CONTRIBUTING doc and I follow the PR guidelines
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tomheller
Copy link
Collaborator

Hi @myieye and thank you for contributing to the barista-components.

Your pull request looks absolutely perfect 😍.
I will be here to help you to finalize the PR to get it merge ready. I will look into why the e2e tests are failing and why the pull request preview action does not pass.

If you have questions at any time, please feel free to reach out.

tomheller
tomheller previously approved these changes Feb 5, 2020
View reviewed changes
@tomheller
Copy link
Collaborator

It seems like the preview cannot be deployed from forks, so this is fine.
The failing e2e test is a flaky one that is already resolved in another pull request and can be ignored.
Everything else seems to be in order. Let's wait for the approval of at least 2 others and then I guess we will be able to merge this one.

@thomaspink
Copy link
Contributor

Hi Tim, thanks for your contribution.

thomaspink
thomaspink suggested changes Feb 6, 2020
View reviewed changes
components/table/src/table.spec.ts Show resolved Hide resolved
components/table/src/table.spec.ts Show resolved Hide resolved
components/empty-state/src/empty-state.ts Outdated Show resolved Hide resolved
@thomaspink thomaspink added the pr: needs-changes This PR has been reviewed and needs changes before it can be merged label Feb 6, 2020
@myieye
feat(empty-state): Allow custom empty-states
a8c5d43 
Enables the usage of custom empty states. This in turn makes empty states reusable.

Closes dynatrace-oss#528
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@lara-aigmueller lara-aigmueller removed the pr: needs-changes This PR has been reviewed and needs changes before it can be merged label Feb 11, 2020
@ffriedl89 ffriedl89 added target: minor This PR is targeted for the next minor release pr: merge-ready This PR is ready to be merged pr: needs-cherry-pick When a pull request needs manual cherry picking labels Feb 13, 2020
@ffriedl89 ffriedl89 merged commit 12f2846 into dynatrace-oss:master Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomheller tomheller tomheller approved these changes

@lukasholzer lukasholzer lukasholzer approved these changes

@ffriedl89 ffriedl89 Awaiting requested review from ffriedl89 ffriedl89 is a code owner

@lara-aigmueller lara-aigmueller Awaiting requested review from lara-aigmueller

@thomaspink thomaspink Awaiting requested review from thomaspink

Assignees
No one assigned
Labels
pr: merge-ready This PR is ready to be merged pr: needs-cherry-pick When a pull request needs manual cherry picking target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EmptyState directive
6 participants
@myieye @tomheller @thomaspink @lukasholzer @ffriedl89 @lara-aigmueller