Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix(drawer): Fixes an issue where the drawer backdrop did not overlay breadcrumbs elements. #605

Merged
merged 1 commit into from
Feb 18, 2020
Merged

fix(drawer): Fixes an issue where the drawer backdrop did not overlay breadcrumbs elements. #605

merged 1 commit into from
Feb 18, 2020

Conversation

tomheller
Copy link
Collaborator

Pull Request

Increased the z-index of the backdrop from 1 to 3.

Fixes #91

Type of PR

Bugfix

Checklist

  • I have read the CONTRIBUTING doc and I follow the PR guidelines
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tomheller
fix(drawer): Fixes an issue where the drawer backdrop did not overlay
c362c57 
breadcrumbs elements.

Increased the z-index of the backdrop from 1 to 3.

Fixes #91
@tomheller tomheller self-assigned this Feb 17, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ffriedl89
ffriedl89 approved these changes Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@ffriedl89 ffriedl89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lukasholzer
lukasholzer approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lukasholzer lukasholzer added the pr: merge-ready This PR is ready to be merged label Feb 18, 2020
@github-actions github-actions bot added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Feb 18, 2020
@tomheller tomheller merged commit 9fbf9c9 into master Feb 18, 2020
@tomheller tomheller deleted the breadcrumbs-arrow branch February 18, 2020 10:17
@github-actions
Copy link

The auto cherry picker succeeded.Cherry picked to minor branch 5.x. New head is now af08ca2
Cherry picked to patch branch 5.2.x. New head is now 3ae0f12

lukasholzer pushed a commit that referenced this pull request Feb 25, 2020
fix(drawer): Fixes an issue where drawer backdrop was overlaying the …
f0415f9 
…drawer body.

Fixes #91 and a regression that was introduced by #605.
@lukasholzer lukasholzer mentioned this pull request Feb 25, 2020
Merged
4 tasks
lukasholzer pushed a commit that referenced this pull request Feb 25, 2020
@lukasholzer
fix(drawer): Fixes an issue where drawer backdrop was overlaying the …
d1a4bb8 
…drawer body.

Fixes #91 and a regression that was introduced by #605.
github-actions bot pushed a commit that referenced this pull request Feb 25, 2020
@lukasholzer
fix(drawer): Fixes an issue where drawer backdrop was overlaying the …
30979f1 
…drawer body.

Fixes #91 and a regression that was introduced by #605.
github-actions bot pushed a commit that referenced this pull request Feb 25, 2020
@lukasholzer
fix(drawer): Fixes an issue where drawer backdrop was overlaying the …
feb3434 
…drawer body.

Fixes #91 and a regression that was introduced by #605.
madina705 pushed a commit to madina705/barista that referenced this pull request Mar 3, 2020
@madina705
fix(drawer): Fixes an issue where drawer backdrop was overlaying the …
5a84798 
…drawer body.

Fixes dynatrace-oss#91 and a regression that was introduced by dynatrace-oss#605.
yngrdyn pushed a commit to yngrdyn/barista that referenced this pull request Nov 9, 2020
fix(drawer): Fixes an issue where drawer backdrop was overlaying the …
f102de5 
…drawer body.

Fixes dynatrace-oss#91 and a regression that was introduced by dynatrace-oss#605.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ffriedl89 ffriedl89 ffriedl89 approved these changes

@lukasholzer lukasholzer lukasholzer approved these changes

@rowa-audil rowa-audil Awaiting requested review from rowa-audil

Assignees

@tomheller tomheller

Labels
pr: merge-ready This PR is ready to be merged target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumbs arrow has higher z-index than the cdk overlay of the sidenav
3 participants
@tomheller @ffriedl89 @lukasholzer