Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix(key-value-list): Change CSS to fix overflow issues fixes #690 #691

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

ddprrt
Copy link
Contributor

@ddprrt ddprrt commented Mar 4, 2020

Pull Request fixes #690

Type of PR

Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc and I follow the PR guidelines
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ddprrt ddprrt requested a review from ffriedl89 as a code owner March 4, 2020 12:19
@ddprrt
Copy link
Contributor Author

ddprrt commented Mar 4, 2020

CC @tomheller

@tomheller tomheller self-requested a review March 4, 2020 12:31
@tomheller
Copy link
Collaborator

Chrome selection behavior has also been fixed with one.
key-value-list-selection

Tested the refactoring of the styles in

Safari
Safari Key value list

Firefox
Safari Key value list

Edge 18
Edge 18 key value list

Chrome
Chrome key value list

@tomheller
Copy link
Collaborator

Amazing fix @ddprrt, thank you for being such a css-magician 🙇

@tomheller tomheller added the pr: needs-cherry-pick When a pull request needs manual cherry picking label Mar 4, 2020
@ddprrt
Copy link
Contributor Author

ddprrt commented Mar 4, 2020

I'm happy because now I actually earned my chocolate :D :D

@sonarcloud
Copy link

sonarcloud bot commented Mar 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomheller tomheller merged commit 19f94d5 into dynatrace-oss:master Mar 5, 2020
@tomheller
Copy link
Collaborator

Manually cherry picked to 6.x and 6.0.x...

@ddprrt ddprrt deleted the definition-list-overflow branch March 5, 2020 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: needs-cherry-pick When a pull request needs manual cherry picking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dt-key-value-list] Expanding selection - text displacement
3 participants