Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fixes SideNav height bug when its content is smaller than view #735

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Fixes SideNav height bug when its content is smaller than view #735

merged 1 commit into from
Mar 16, 2020

Conversation

rowa-audil
Copy link
Contributor

Changes SideNav Height property from 100% to 100vh

@rowa-audil rowa-audil self-assigned this Mar 13, 2020
@rowa-audil rowa-audil added the bug A broken behaviour that was working previously label Mar 13, 2020
@rowa-audil rowa-audil linked an issue Mar 13, 2020 that may be closed by this pull request
Sidenav height bug when content is smaller than the view #733
Closed
@github-actions
Copy link

github-actions bot commented Mar 13, 2020 •
edited
Loading

Deploy preview for website ready!

Built with commit ab5156b

https://barista-design-system-1nr1jz1ix.now.sh

lukasholzer
lukasholzer previously approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasholzer
Copy link
Contributor

Is there an issue connected with this PR?

@lukasholzer
Copy link
Contributor

lukasholzer commented Mar 13, 2020 •
edited
Loading

Maybe you can reword your commit to something more descriptive for the changelog:

The scope would be drawer in case you import it from @dynatrace/barista-components/drawer

`fix(drawer): Fixes an issue where the side navigation drawer was not expanding to the full-screen height.

Fixes #733. This issue originated when a side navigation was in use where the content of it was smaller than the window height.`

@rowa-audil
Copy link
Contributor Author

Yes: #733

@lukasholzer lukasholzer added the pr: needs-rebase This PR needs rebasing label Mar 13, 2020
@lukasholzer
Copy link
Contributor

please add issue number in commit body.

@rowa-audil
fix(drawer): Fixes an issue where the side navigation drawer was not …
eab5c59 
…expanding to the full-screen height.

Fixes #733. This issue originated when a side navigation was in use where the content of it was smaller than the window height.
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lukasholzer lukasholzer removed the pr: needs-rebase This PR needs rebasing label Mar 16, 2020
@lukasholzer lukasholzer added the pr: merge-ready This PR is ready to be merged label Mar 16, 2020
@github-actions github-actions bot added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Mar 16, 2020
@ffriedl89 ffriedl89 merged commit 350b95f into master Mar 16, 2020
@ffriedl89 ffriedl89 deleted the fix-sidenav-height-bug branch March 16, 2020 08:30
@github-actions
Copy link

The auto cherry picker succeeded.Cherry picked to minor branch 6.x. New head is now dd2ccf2
Cherry picked to patch branch 6.0.x. New head is now 071959d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukasholzer lukasholzer lukasholzer approved these changes

@tomheller tomheller Awaiting requested review from tomheller tomheller is a code owner

Assignees

@rowa-audil rowa-audil

Labels
bug A broken behaviour that was working previously pr: merge-ready This PR is ready to be merged target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidenav height bug when content is smaller than the view
3 participants
@rowa-audil @lukasholzer @ffriedl89