-
Notifications
You must be signed in to change notification settings - Fork 78
Fixes SideNav height bug when its content is smaller than view #735
Conversation
Deploy preview for website ready! Built with commit ab5156b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there an issue connected with this PR? |
Maybe you can reword your commit to something more descriptive for the changelog: The scope would be drawer in case you import it from `fix(drawer): Fixes an issue where the side navigation drawer was not expanding to the full-screen height. Fixes #733. This issue originated when a side navigation was in use where the content of it was smaller than the window height.` |
Yes: #733 |
please add issue number in commit body. |
…expanding to the full-screen height. Fixes #733. This issue originated when a side navigation was in use where the content of it was smaller than the window height.
3e11568
to
eab5c59
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Changes SideNav Height property from 100% to 100vh