Check for inconsistent gauge fields for summaries #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirgeo
requested review from
joaopgrassi,
arminru,
pichlermarc and
evan-bradley
joaopgrassi
approved these changes
Jan 10, 2024
lib/src/main/java/com/dynatrace/metric/util/NumberValueValidator.java
Outdated
Show resolved
Hide resolved
arminru
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric lines that contain inconsistent gauge fields (i.e., where the min is larger than the average or where the average is larger than the maximum) will be rejected by the Dynatrace API. In order to save network bandwidth, and to get immediate information about which metrics are invalid, this change drops the metric lines on the client side now. Note that this does not change the data that is stored in Dynatrace, just the place where the inconsistent data is dropped (client side vs. API).