This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Use Dynatrace.MetricUtils NuGet package #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…csSerializer for consistency.
pirgeo
approved these changes
Sep 29, 2021
src/Dynatrace.OpenTelemetry.Exporter.Metrics.Tests/DynatraceMetricsExporterTests.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsMapper.cs
Outdated
Show resolved
Hide resolved
joaopgrassi
suggested changes
Sep 30, 2021
src/Dynatrace.OpenTelemetry.Exporter.Metrics/Dynatrace.OpenTelemetry.Exporter.Metrics.csproj
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsExporter.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsExporter.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsExporter.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsMapper.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsMapper.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsMapper.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsMapper.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsMapper.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsMapper.cs
Outdated
Show resolved
Hide resolved
…roduce extension on Metric.
pirgeo
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Looking good to me, I think both you and @joaopgrassi have done a great job in making sure this is a high-quality PR!
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsExporter.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsExporter.cs
Outdated
Show resolved
Hide resolved
src/Dynatrace.OpenTelemetry.Exporter.Metrics/DynatraceMetricsExtensions.cs
Outdated
Show resolved
Hide resolved
joaopgrassi
suggested changes
Oct 1, 2021
src/Dynatrace.OpenTelemetry.Exporter.Metrics.Tests/DynatraceMetricsExporterTests.cs
Show resolved
Hide resolved
joaopgrassi
approved these changes
Oct 1, 2021
arminru
reviewed
Oct 1, 2021
src/Dynatrace.OpenTelemetry.Exporter.Metrics/Dynatrace.OpenTelemetry.Exporter.Metrics.csproj
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt
Dynatrace.OpenTelemetry.Export.Metricsto use theDynatrace.MetricUtilspackage and remove unused code.