fix: fopen for fwrite use binary mode

this avoids adding a carriage return on windows
dyne · Dec 15, 2024 · 63991de · 63991de
1 parent fcad0d7
commit 63991de
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/muntar.c b/src/muntar.c
@@ -157,11 +157,11 @@ static int mtar_rewind(mtar_t *tar) {
 ///////////////////
 
 
-#include <sys/stat.h> // for mkdir(2)
 #if defined(_WIN32)
 #include <windows.h>
 #define makedir(path) CreateDirectory(path, NULL)
 #else
+#include <sys/stat.h>
 #define makedir(path) mkdir(path,0755)
 #endif
 // used by extract_embeddings(char *tmpdir)
@@ -219,7 +219,7 @@ int untar_to_path(const char *path, const uint8_t *buf,
 			const size_t namelen = strlen(header->name);
 			if(p-tpath+namelen>1023) return(MTAR_EOPENFAIL);
 			strcpy(p,header->name);
-			FILE *fp = fopen(tpath,"w");
+			FILE *fp = fopen(tpath,"wb");
 			if(!fp) {
 				fprintf(stderr,
 					"Error open file for write: %s\n",

diff --git a/test/muntar.bats b/test/muntar.bats
@@ -95,7 +95,7 @@ int main(int argc, char **argv) {
         free(dest);
         exit(res);
     }
-    FILE *fp = fopen("examples_uncompressed.tar","w");
+    FILE *fp = fopen("examples_uncompressed.tar","wb");
     if(!fp) {
         fprintf(stderr,
                 "Error open file for write: %s\n",