Provided base class virtual for getABIVersion() that returns false when not implemented #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object.h. The virtual function in this base class now returns false indicating that it is not implemented (which is the case for Object-nt).
|
Fixes #21 |
|
When I was running some tests locally, I noticed some strange proccontrol test failures. I found that these failures were not due to my change, but were instead due to the fact that I was running against the wrong branch of testsuite. |
|
This pull request is now ready. I believe that it fixes #21. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed forgotten rename of isPPC64V2API to getABIVersion in
Object.h. The virtual function in this base class now returns
false indicating that it is not implemented (which is the case
for Object-nt).