feat: Add Kiro IDE and Kiro CLI support with global mode#785
Closed
maekawataiki wants to merge 4 commits intodyoshikawa:mainfrom
Closed
feat: Add Kiro IDE and Kiro CLI support with global mode#785maekawataiki wants to merge 4 commits intodyoshikawa:mainfrom
maekawataiki wants to merge 4 commits intodyoshikawa:mainfrom
Conversation
Owner
|
@maekawataiki Thank you so much. However this PR is too large to me. So please split it. For example, first, you can create a PR about Skills feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive support for Kiro IDE and Kiro CLI as new tool targets, including global mode support for both.
Features Added
✅ = project mode, 🌏 = global mode
Implementation Details
Kiro IDE:
Kiro CLI:
Technical Changes
Why outputBaseDir was added to toRulesyncMcp()
In global mode, two directories diverge:
According to the README, global mode should work from any directory (e.g., ~/.aiglobal):
However, the current main branch implementation writes to
~/.rulesync/rules/CLAUDE.mdregardless ofprocess.cwd(), because toRulesyncMcp() uses baseDir (home directory in global mode) for output.This PR changes the default output to process.cwd(), matching the README's documented behavior.
Question for maintainer: Which behavior is intended?
If option 1 is intended, I'll revert this change and update the README instead.
Alternatively, if the global mode design isn't finalized yet, I can remove global mode support from this PR entirely and focus only on project mode for
Kiro IDE/CLI. We can add global support in a follow-up PR once the design is settled.
Testing
All tests passing. pnpm cicheck:code passes.