Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix #412

Merged
merged 2 commits into from
Jun 15, 2024
Merged

hotfix #412

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68632a5
hotfix
blooop Jun 15, 2024
13ec904
update pixi.lock
blooop Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions 1setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
from setuptools import setup, find_packages

package_name = "bencher"

setup(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

name=package_name,
description="A library for benchmarking code and generating reports for analysis",
# maintainer="austin.gregg-smith",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Commented-out maintainer information

The maintainer and maintainer_email fields are commented out. If this is intentional for a temporary reason, consider adding a comment explaining why. Otherwise, it might be better to either include or remove these lines.

# maintainer_email="austin.gregg-smith@dyson.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Commented-out maintainer email

Similar to the maintainer field, the maintainer_email field is commented out. If this is intentional for a temporary reason, consider adding a comment explaining why. Otherwise, it might be better to either include or remove these lines.

packages=find_packages(exclude=["test.*", "test"]),
data_files=[
("share/ament_index/resource_index/packages", ["resource/" + package_name]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Hardcoded paths in data_files

Consider using os.path.join for constructing file paths to ensure compatibility across different operating systems.

Suggested change
("share/ament_index/resource_index/packages", ["resource/" + package_name]),
import os
data_files=[
("share/ament_index/resource_index/packages", [os.path.join("resource", package_name)]),
("share/" + package_name, ["package.xml"]),
]

("share/" + package_name, ["package.xml"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Hardcoded paths in data_files

Similar to the previous line, consider using os.path.join for constructing file paths to ensure compatibility across different operating systems.

Suggested change
("share/" + package_name, ["package.xml"]),
import os
data_files=[
("share/ament_index/resource_index/packages", ["resource/" + package_name]),
(os.path.join("share", package_name), ["package.xml"]),
],

],
zip_safe=False,
test_suite="test",
tests_require=["pytest"],
)
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "bencher"
version = "1.26.1"
version = "1.26.2"

authors = [{ name = "Austin Gregg-Smith", email = "blooop@gmail.com" }]
description = "A package for benchmarking the performance of arbitrary functions"
Expand Down
Loading