feat: Adding changes for persist Chat and also a change in Patch for … #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meeting.chatSynced
roerohan
requested changes
Apr 5, 2024
static/api/v2.yaml
Outdated
| type: boolean | ||
| x-stoplight: | ||
| id: 1rdw9emd9qk8y | ||
| description: 'If a meeting is updated to persist_chat, meeting chat would remain for a week within the meeting space' |
There was a problem hiding this comment.
Any specific reason for changing these to single quotes? I think stoplight generates double quotes automatically.
static/api/v2.yaml
Outdated
| @@ -4942,7 +4946,7 @@ components: | |||
| type: boolean | |||
| x-stoplight: | |||
| id: k1f2cjsd28631 | |||
| description: "Controls whether recordings are uploaded to Dyte's bucket. If set to false, `download_url`, `audio_download_url`, `download_url_expiry` won't be generated for a recording." | |||
| description: 'Controls whether recordings are uploaded to Dyte bucket. If set to false, `download_url`, `audio_download_url`, `download_url_expiry` won''t be generated for a recording.' | |||
There was a problem hiding this comment.
The quote in won't will be missing with this change, we'll need to escape it \'
vinya-jag
commented
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for Persist Chat (Addition) into
Create Meetings, Update, and Fetch
Small edit into Patch Request for meeting in this page
https://docs.dyte.io/api?v=v2#/operations/editWebhook
…meeting.chatSynced
Checks done:
No errors on Swagger Editor
Source:
StopLight vinayEdit fork.
Have cleaned up this Fork of all Swagger Misalignments, and made it fully useable.
Please us this for any future edits.
Description
Describe your PR here.
Resolved issues
Closes #1
Before submitting the PR, please take the following into consideration
feat:,fix:,chore:,docs:, orrefactor:.mainbranch.