Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: contributor page #610

Merged
merged 11 commits into from
Dec 17, 2024
Merged

feat: contributor page #610

merged 11 commits into from
Dec 17, 2024

Conversation

ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Oct 5, 2024

  • going to /team/[slug] will load detailed contributor page
  • the page contains general info about the contributor and lists all related projects and open contributions.
  • open-graph info are populated for each contributor link

eg: https://stage.dzcode.io/team/github-linuxscout

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (changes that require a fresh clone of the repo)
  • I'm not sure

@github-actions github-actions bot added the web Web related changes ( web folder ) label Oct 5, 2024
Base automatically changed from switch-to-postgres to main October 5, 2024 14:53
@github-actions github-actions bot added feature Feature api API related changes ( api folder ) labels Oct 5, 2024
@ZibanPirate ZibanPirate marked this pull request as ready for review December 16, 2024 20:07
@ZibanPirate ZibanPirate requested a review from a team December 16, 2024 20:22
"start:dev": "tsx ../packages/tooling/nodemon.ts \"@dzcode.io/api\" && npm-run-all --parallel start:nodemon db:server",
"start:nodemon": "wait-port localhost:5432 && nodemon dist/app/index.js",
"start:nodemon": "wait-port localhost:5432 && delay 2 && nodemon dist/app/index.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need delay here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on my M1, postgres server is up, but you can't query it until few seconds after, so wait-port alone is not enough.

i only added this delay for the dev script start:nodemon

@ZibanPirate ZibanPirate merged commit c764268 into main Dec 17, 2024
36 checks passed
@ZibanPirate ZibanPirate deleted the profile-page branch December 17, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API related changes ( api folder ) feature Feature web Web related changes ( web folder )
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants