Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Search #624

Merged
merged 19 commits into from
Dec 24, 2024
Merged

Global Search #624

merged 19 commits into from
Dec 24, 2024

Conversation

omdxp
Copy link
Member

@omdxp omdxp commented Dec 24, 2024

  • Add full flow for searching.
  • Make shared component cards for search results and corresponding pages.
  • Add global search input component.
  • Bug fix
  • New feature
  • Other

@omdxp omdxp requested a review from a team December 24, 2024 09:24
@omdxp omdxp self-assigned this Dec 24, 2024
@github-actions github-actions bot added feature Feature web Web related changes ( web folder ) api API related changes ( api folder ) labels Dec 24, 2024
@omdxp omdxp mentioned this pull request Dec 24, 2024
Closed
4 tasks
@omdxp omdxp added this to the Search functionality milestone Dec 24, 2024
@omdxp omdxp marked this pull request as draft December 24, 2024 12:32
@omdxp omdxp marked this pull request as ready for review December 24, 2024 13:21
ZibanPirate
ZibanPirate requested changes Dec 24, 2024
View reviewed changes
Copy link
Member

@ZibanPirate ZibanPirate left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, Looks awesome!

added few comments on the code, and since these [model]-card.tsx components are re-used by the Search component, let's move them up under src/components/

Looks great otherwise!

api/src/app/endpoints.ts Outdated Show resolved Hide resolved
web/src/_entry/app.tsx Outdated Show resolved Hide resolved
web/src/components/top-bar.tsx Outdated Show resolved Hide resolved
web/src/components/top-bar.tsx Outdated Show resolved Hide resolved
web/src/components/top-bar.tsx Outdated Show resolved Hide resolved
web/src/pages/team/contributor-card/index.tsx Outdated Show resolved Hide resolved
web/src/utils/search.ts Outdated Show resolved Hide resolved
web/src/components/search.tsx Outdated Show resolved Hide resolved
web/src/components/search.tsx Outdated Show resolved Hide resolved
web/src/components/search.tsx Outdated Show resolved Hide resolved
omdxp added 7 commits December 24, 2024 17:24
@omdxp omdxp requested a review from ZibanPirate December 24, 2024 16:56
ZibanPirate
ZibanPirate reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@ZibanPirate ZibanPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few mostly-optional comments, apart from the bug comment (we should note that down)

web/src/utils/search.ts Outdated Show resolved Hide resolved
web/src/utils/search-modal.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it makes sense for this to live inside web/src/components/search.tsx

web/src/components/search.tsx Outdated Show resolved Hide resolved
web/src/components/top-bar.tsx Outdated Show resolved Hide resolved
web/src/components/contributor-card.tsx Show resolved Hide resolved
@omdxp omdxp requested a review from ZibanPirate December 24, 2024 18:04
ZibanPirate
ZibanPirate approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@ZibanPirate ZibanPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🔎 pretty fast on staging already

@omdxp omdxp merged commit 58ea3c9 into main Dec 24, 2024
20 checks passed
@omdxp omdxp deleted the global-search branch December 24, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZibanPirate ZibanPirate ZibanPirate approved these changes

Assignees

@omdxp omdxp

Labels
api API related changes ( api folder ) feature Feature web Web related changes ( web folder )
Projects
DzCode i/o
Status: Merged
Milestone
Search functionality
Development

Successfully merging this pull request may close these issues.
2 participants
@omdxp @ZibanPirate