merge more config file settings into config #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried setting
editor_cmd
in my.projectable.toml
file.. expecting it to override both the defaultvi
and$EDITOR
env.It doesn't get used by the application.
This PR adds a few "missing" fields to the merge part of the configuration.
If these are omitted by design.. please feel free to discard this PR.
NOTE: this change gives (local) config precedence over env which might not be what is desired. Maybe the order of evaluation should be 1): env -> local config -> global config -> default
With this PR it appears to become 2): local config -> global config -> env -> default
Without this PR it is 3): env -> default