Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for whether jq is installed in the system #162

Merged
merged 1 commit into from
May 31, 2022

Conversation

rchl
Copy link
Contributor

@rchl rchl commented Dec 8, 2021

The check for the existence of jq using shutil.which didn't really work since shutil.which does not ever throw so jq_exists have always been True, even if jq was missing on the system.

Fixed that and also:

  • replace status message saying that JQ is missing with a dialog that also allows opening the JQ website (having a link in a status field wasn't a great idea since it was not possible to click it).
  • remove unnecessary globals and just check if jq is available on every invocation. The caching of state is not necessary since this is never gonna be a performance issue. Also it would cache too hard, even after the user has changed the jq_binary in settings.

@TerminalFi TerminalFi merged commit f844dfd into dzhibas:master May 31, 2022
@rchl rchl deleted the fix/jq-check branch May 31, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants