Refine tf mnist #47
Merged
Refine tf mnist #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
force-pushed
the
feature/refine_tf_mnist
branch
from
47a1a0b
to
655f769
Compare
pkuyym
reviewed
Jan 11, 2018
| test_avg_acc = eval_test() | ||
| print("pass=%d, training_avg_accuracy=%f, test_avg_acc=%f, elapse=%f" % | ||
| (pass_id, g_acc[1], test_avg_acc, (pass_end - pass_start) / 1000)) | ||
| return g_acc[1] |
There was a problem hiding this comment.
Be careful here, tf.metrics.accuracy will accumulate the acc. Please make sure to reset the accumulating variables each time doing validation. You can refer tensorflow/tensorflow#4814 (comment)
pkuyym
reviewed
Jan 11, 2018
tensorflow/mnist.py
Outdated
| test_avg_acc = eval_test() | ||
| print( | ||
| "pass=%d, training_avg_accuracy=%f, test_avg_acc=%f, elapse=%f" | ||
| % (pass_id, g_acc[1], test_avg_acc, |
There was a problem hiding this comment.
Same as above, I think better to reset the accumulating state in the begin of each epoch.
chengduoZH
force-pushed
the
feature/refine_tf_mnist
branch
from
8644211
to
2d35e14
Compare
chengduoZH
force-pushed
the
feature/refine_tf_mnist
branch
from
2d35e14
to
b796d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.