Extracted condtion to method

Encapsulate Conditionals (see: http://geekswithblogs.net/ramkinkarpandey/archive/2010/01/03/how-to-write-a-good-code--2.aspx)
dziemid · Nov 24, 2011 · 355aad8 · 355aad8
1 parent 9e9ef1c
commit 355aad8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/java/string_calculator/src/main/java/StringCalculator.java b/java/string_calculator/src/main/java/StringCalculator.java
@@ -3,7 +3,7 @@ public int add(String s) {
  if (s.isEmpty()) {
  return 0;
  }
- if (s.startsWith("//")) {
+ if (hasCustomSeparator(s)) {
  int returnValue = 0;
  for (String n : s.substring(4).split("[\n"+ s.charAt(2) +"]")) {
  returnValue += Integer.parseInt(n);
@@ -17,4 +17,8 @@ public int add(String s) {
  return r;
  }
  }
+
+ private boolean hasCustomSeparator(String s) {
+ return s.startsWith("//");
+ }
 }