Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to JDK21 #1960

Closed
Tracked by #1999
dzikoysk opened this issue Oct 22, 2023 · 8 comments
Closed
Tracked by #1999

Move to JDK21 #1960

dzikoysk opened this issue Oct 22, 2023 · 8 comments
Labels
dependencies Pull requests that update a dependency file distribution Issue refers to target platform, e.g. Docker

Comments

@dzikoysk
Copy link
Owner

dzikoysk commented Oct 22, 2023 •
edited
Loading

reposilite-playground/reposilite-aur#21
@dzikoysk dzikoysk added the dependencies Pull requests that update a dependency file label Oct 22, 2023
dzikoysk added a commit that referenced this issue Oct 23, 2023
@dzikoysk
GH-1960 Gradle 8.4 & JDK 21 on CI
b72e146
dzikoysk added a commit that referenced this issue Oct 23, 2023
@dzikoysk
GH-1960 Kotlin 1.9.20-RC
9df58dc
dzikoysk added a commit that referenced this issue Oct 23, 2023
@dzikoysk
GH-1960 Force Kotlin 1.9.20-RC in Gradle toolchain setup
e99a728
@dzikoysk
Copy link
Owner Author

Blocked by:

dzikoysk added a commit that referenced this issue Oct 23, 2023
@dzikoysk
GH-1960 Downgrade to JDK20 & Kotlin 1.9.10
8b70c40
@dzikoysk dzikoysk mentioned this issue Oct 23, 2023
Closed
@PolarianDev
Copy link
Contributor

Caused by: java.lang.IllegalArgumentException: Unknown Kotlin JVM target: 21

So java is working with gradle 8.4 but Kotlin is yet to follow.

Welp Java 20 is good enough.

@dzikoysk
Copy link
Owner Author

It's an issue with Gradle, not Kotlin atm. We can manually bump Kotlin version in Gradle, but later on it'll throw exceptions on Kapt + if we'll explicitly set JDK21 in the toolchain for Gradle, it'll fail on CI with JDK11.

@PolarianDev
Copy link
Contributor

In other words, not mature enough yet. It was worth a try I guess.

Migrate to jdk21 when the issue is solved?

@dzikoysk
Copy link
Owner Author

Yup, we need to wait for sth like Gradle 8.4.1/8.5

dzikoysk added a commit that referenced this issue Nov 10, 2023
@dzikoysk
GH-1960 Let's stay on jdk20
299ffb3
@dzikoysk dzikoysk reopened this Nov 10, 2023
@dzikoysk dzikoysk mentioned this issue Nov 11, 2023
Closed
@dzikoysk
Copy link
Owner Author

Gradle 8.5-rc.1 supports JDK21, but Kapt (Kotlin's annotation processor adapter) is unable to start, so we need to wait for next RC/official release.

@dzikoysk
Copy link
Owner Author

Related issue:

It looks like the fix targets Kotlin 2.0, but not 1.9.20. It's a bit strange.

@dzikoysk dzikoysk added the distribution Issue refers to target platform, e.g. Docker label Nov 12, 2023
@dzikoysk
Copy link
Owner Author

In theory, it should work with 1.9.21:

@dzikoysk dzikoysk mentioned this issue Dec 5, 2023
Closed
5 tasks
dzikoysk added a commit that referenced this issue Dec 23, 2023
@dzikoysk
GH-1960 Use JDK21 in official Docker image and make sure Loom is disa…
9aab648 
…bled in Javalin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file distribution Issue refers to target platform, e.g. Docker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dzikoysk @PolarianDev