Skip to content

Commit

Permalink
Remove useless min temp and max temp settings.
Browse files Browse the repository at this point in the history
Simplify login check.
Limit temp step.
Control fan quite mode in the Unit settings
  • Loading branch information
dzungpv committed Oct 27, 2023
1 parent 4b13c66 commit c07ebee
Show file tree
Hide file tree
Showing 6 changed files with 134 additions and 98 deletions.
8 changes: 5 additions & 3 deletions main/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ unsigned long requestWifiScanTime = 0;
#define WIFI_SCAN_PERIOD 120000
unsigned lastWifiScanMillis;

const PROGMEM char* m2mqtt_version = "2023.8.0";
const PROGMEM char* m2mqtt_version = "2023.10.0";

//Define global variables for files
#ifdef ESP32
Expand Down Expand Up @@ -205,8 +205,8 @@ bool _debugModeLogs = false;
bool _debugModePckts = false;

// Customization
uint8_t min_temp = 16; // Minimum temperature, in your selected unit, check value from heatpump remote control
uint8_t max_temp = 31; // Maximum temperature, in your selected unit, check value from heatpump remote control
const uint8_t min_temp = 16; // Minimum temperature, in your selected unit, check value from heatpump remote control
const uint8_t max_temp = 31; // Maximum temperature, in your selected unit, check value from heatpump remote control
String temp_step = "1"; // Temperature setting step, check value from heatpump remote control

// sketch settings
Expand All @@ -224,6 +224,8 @@ const PROGMEM uint32_t HP_MAX_RETRIES = 10; // Double the interval between retri
bool useFahrenheit = false;
// support heat mode settings, some model do not support heat mode
bool supportHeatMode = true;
// support quiet mode for fan settings, some model do not support quite mode: MSZ-GE35VA, MSZ-GE71VA, MSZ-GE25VA https://github.com/SwiCago/HeatPump/issues/162
bool supportQuietMode = true;

// info in status page
String version = ""; /* Git version */
Expand Down
10 changes: 1 addition & 9 deletions main/html_pages.h
Original file line number Diff line number Diff line change
Expand Up @@ -305,17 +305,9 @@ const char html_page_unit[] PROGMEM =
"<option value='fah' _TU_FAH_>_TXT_F_FH_</option>"
"</select>"
"</p>"
"<p><b>_TXT_UNIT_MINTEMP_</b>"
"<br/>"
"<input type='number' id='min_temp' name='min_temp' placeholder=' ' value='_MIN_TEMP_'>"
"</p>"
"<p><b>_TXT_UNIT_MAXTEMP_</b>"
"<br/>"
"<input type='number' id='max_temp' name='max_temp' placeholder=' ' value='_MAX_TEMP_'>"
"</p>"
"<p><b>_TXT_UNIT_STEPTEMP_</b>"
"<br/>"
"<input type='number' id='temp_step' step='0.1' name='temp_step' placeholder=' ' value='_TEMP_STEP_'>"
"<input type='number' id='temp_step' step='0.1' min='0.1' max='1.0' name='temp_step' placeholder=' ' value='_TEMP_STEP_'>"
"</p>"

"<p>"
Expand Down
2 changes: 0 additions & 2 deletions main/language_translations.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ MAKE_WORD_TRANSLATION(txt_unit_password, en::txt_unit_password, vi::txt_unit_pas
MAKE_WORD_TRANSLATION(txt_unit_password_confirm, en::txt_unit_password_confirm, vi::txt_unit_password_confirm) // TODO translate
MAKE_WORD_TRANSLATION(txt_unit_password_not_match, en::txt_unit_password_not_match, vi::txt_unit_password_not_match) // TODO translate
MAKE_WORD_TRANSLATION(txt_unit_login_username, en::txt_unit_login_username, vi::txt_unit_login_username) // TODO translate
MAKE_WORD_TRANSLATION(txt_unit_1_0_steptemp, en::txt_unit_1_0_steptemp, vi::txt_unit_1_0_steptemp) // TODO translate
MAKE_WORD_TRANSLATION(txt_unit_0_5_steptemp, en::txt_unit_0_5_steptemp, vi::txt_unit_0_5_steptemp) // TODO translate

// Page Login
MAKE_WORD_TRANSLATION(txt_login_title, en::txt_login_title, vi::txt_login_title) // TODO translate
Expand Down
2 changes: 0 additions & 2 deletions main/languages/en-GB.h
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ namespace en
const char txt_unit_password_confirm[] PROGMEM = "Confirm Login password";
const char txt_unit_password_not_match[] PROGMEM = "Confirm Password did not match";
const char txt_unit_login_username[] PROGMEM = "Note: Default login user is";
const char txt_unit_1_0_steptemp[] PROGMEM = "1.0 degree";
const char txt_unit_0_5_steptemp[] PROGMEM = "0.5 degree";

// Page Login
const char txt_login_title[] PROGMEM = "Authentication";
Expand Down
2 changes: 0 additions & 2 deletions main/languages/vi-VN.h
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ namespace vi
const char txt_unit_password_confirm[] PROGMEM = "Xác nhận Mật khẩu đăng nhập";
const char txt_unit_password_not_match[] PROGMEM = "Mật khẩu nhập lại không đúng";
const char txt_unit_login_username[] PROGMEM = "Ghi chú: Tài khoản đăng nhập mặc định là:";
const char txt_unit_1_0_steptemp[] PROGMEM = "1.0 độ";
const char txt_unit_0_5_steptemp[] PROGMEM = "0.5 độ";

// Page Login
const char txt_login_title[] PROGMEM = "Xác thực";
Expand Down
Loading

0 comments on commit c07ebee

Please sign in to comment.