Extract client handling into Client module #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
Extracted class and instance-level management of the Redis client object into a new
Client
module. The client still defaults toRedis.current
, which can be overridden at the class-level for all time series, or provided as an option to the instance for only one series.Moved argument parsing into the
Client
module. Args passed to thecmd
call will be automaticallyflatten
ed,compact
ed, and have Time objects converted to their millisecond timestamp representation. This cleans up a lot of repetitive code at the call sites, and also means thatcmd
can be called with positional arguments, eliminating an intermediateargs
array.Note that the class-level methods like
.query_index
can only use the class-level client.Removed the
@retention
and@uncompressed
instance variables..create
.info
hashuncompressed
param to TS.ADD, TS.INCRBY, TS.DECRBY #31 for pending changes toUNCOMPRESSED