Skip to content

Conversation

pifuchs
Copy link

@pifuchs pifuchs commented Sep 24, 2025

@nico-mcalley
Copy link
Collaborator

Hi Timo,
thank you for the PR. I had an initial look.
Could you please provide more context about the use case these changes are intended to support?

Additionally, the tests are currently failing.
It looks like the test infrastructure needs to be adjusted to reflect the interface changes you introduced.
Best regards Nico

P.S. Greetings from Peter

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds translation status information to the Page interface and its mapping functionality. The change includes a new translated boolean field that indicates whether a page has been translated.

  • Add translated boolean field to both CaaSApi_Page and Page interfaces
  • Update CaaSMapper to populate the translated field from the API response

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/types.ts Adds translated: boolean field to CaaSApi_Page and Page interfaces
src/modules/CaaSMapper.ts Maps the translated field from pageRef.page.translated to the Page object

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants