Add device_id and device_name and tests for virtual_machine #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w87x
pushed a commit
to w87x/terraform-provider-netbox
that referenced
this pull request
Oct 5, 2023
…nger#477) * Add device_id and device_name and tests * Restore removed var
w87x
pushed a commit
to w87x/terraform-provider-netbox
that referenced
this pull request
Oct 5, 2023
…nger#477) * Add device_id and device_name and tests * Restore removed var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no associated Issue/Feature Request, but I went to use this provider with the ProxMox provider and a few other things, and I realised that I needed the Device Name and/or the Device ID.
This update simply adds the required values/fields to the data source.
NOTE: There are a number of lines that start with "var" that were removed. It appears that go linters prefer lines like
var thing = "Hello"to instead look similar to
thing := "Hello"