-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add field 'parent_id' to Location Resource & Data Source #548
Conversation
Can you add a test that UNSETs the parent_id? I assume it will fail because of reasons similar to the linked issue. I will then fix it in fbreckle/go-netbox, if necessary. |
You're right, the update doesn't work.
What could be wrong? p.s. Docker at macOS on ARM CPU. |
Googling the error gives me mostly "out of memory" results. I will generate a branch with the change for you. |
Change is at https://github.com/fbreckle/go-netbox/tree/feature/parent_id You should be able to use |
Did a quick check. Looks like it works :) |
Can you add the test that unsets a parent id as well? Else LGTM Just add one more step to one of the tests where the parent id is unset and then check if its actually unset or 0 or whatever. |
|
c1e0e74
to
53e0120
Compare
53e0120
to
4e398e2
Compare
Hello there!
We actively use Location nesting. And I really miss the ability to read and write the “parent_id” value in a DCIM model resource Location.
This PR is about the same as in #508.
PTAL.