Add resource to manage virtual disks #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the addition of virtual disks, this field represents the aggregate size of all disks. When adding virtual disks, netbox automatically updates this field, so it must be a `computed` field to let terraform know that there can be changes from outside of terraform.
|
Needs fbreckle/go-netbox#37 before this works. |
|
I was working on fbreckle/go-netbox#37 and created this code to verify it actually works. |
…29093931-1ddc00b277c1
Add support to manage [virtual disks][0], which were added in netbox 3.7.0. [0]:https://docs.netbox.dev/en/stable/models/virtualization/virtualdisk/
Ikke
force-pushed
the
resource-virtual-disk
branch
from
3de77f3 to
7435e66
Compare
fbreckle
reviewed
Feb 29, 2024
|
Hello together, |
|
It sure is possible, somebody just has to find the time to do it.. #557 stays open as a reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to manage virtual disks, which were added in netbox
3.7.0.
This does affect the
netbox_virtual_machineresource because adding virtual disks to a VM does adjust thedisk_size_gbproperty. We solve this by setting that field to computed.