Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add filter for status in virtual machines data source #612

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

twink0r
Copy link
Contributor

@twink0r twink0r commented Jun 27, 2024

No description provided.

@twink0r
Copy link
Contributor Author

twink0r commented Jun 27, 2024

Any ideas why this fails in the pipeline? Local the tests looks fine

@fbreckle
Copy link
Collaborator

This happens because the tests run in parallel an there is a race condition where one test creates VMs that other tests then find.
This happens often with pluralized data source tests. I assume your local machine has more power than the github runners, so it happens less in local executions.
Changing resource.ParallelTest( to resource.Test( might work. Or make the other filters more narrow so they do not include your test vms.

@twink0r
Copy link
Contributor Author

twink0r commented Jun 27, 2024

I changed it, but some other data source test is failing now

@fbreckle fbreckle merged commit aac34b5 into e-breuninger:master Jul 30, 2024
@twink0r twink0r deleted the add-vm-status-filter branch August 2, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants