This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Dokumentide samaaegse saatmise piiramine #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martenrebane
commented
May 6, 2020
martenrebane
commented
- DHX-32
* DHX-32
vellotis
suggested changes
May 6, 2020
| @@ -100,6 +99,7 @@ | |||
| @Rule | |||
| public TemporaryFolder testFolder = new TemporaryFolder(); | |||
| String filename = "trying"; | |||
| String folderName = "folder"; | |||
There was a problem hiding this comment.
Make both of them static and final as they are constants.
| import ee.ria.dhx.server.persistence.entity.Sender; | ||
| import ee.ria.dhx.server.persistence.entity.StatusHistory; | ||
| import ee.ria.dhx.server.persistence.entity.Transport; | ||
| import ee.ria.dhx.server.persistence.entity.*; |
There was a problem hiding this comment.
Do not use wildcard imports
| import ee.ria.dhx.server.types.ee.riik.xrd.dhl.producers.producer.dhl.SendDocumentsV4RequestType; | ||
| import ee.ria.dhx.server.types.ee.riik.xrd.dhl.producers.producer.dhl.SendDocumentsV4ResponseTypeUnencoded; | ||
| import ee.ria.dhx.server.types.ee.riik.xrd.dhl.producers.producer.dhl.TagasisideType; | ||
| import ee.ria.dhx.server.types.ee.riik.xrd.dhl.producers.producer.dhl.*; |
There was a problem hiding this comment.
Do not use wildcard imports
* DHX-32
vellotis
approved these changes
May 6, 2020
|
https://github.com/martenrebane/DHX-adapter/blob/add98e3e464a2301f944f0fbec22263c1bf76f58/dhx-adapter-server/src/main/resources/templates/document-status.html#L25 |
* DHX-32
KristjanKruusRIA
added a commit
that referenced
this pull request
May 11, 2020
* Dokumentide samaaegse saatmise piiramine * DHX-32 * Liquibase script refactoring * DHX-32 * Code review fixes * DHX-32 * Changed Kaust name reference * DHX-32 * DHX-32 - This commit is a dirty fix to a `vastuvotja`(recipient) table record locking problem happening during sending documents to the another DHX Co-authored-by: Marten Rebane <marten.rebane@nortal.com> Co-authored-by: Kaarel Raspel <kaarel.raspel@nortal.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.