Fix usage example in README.md #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronius
commented
Nov 12, 2021
|
|
||
| configuration := configuration.New( | ||
| configuration.TestEnvironment, | ||
| &configuration.Pkcs12{Content: certificate), Password: "p12 password"}, |
There was a problem hiding this comment.
here we had an extra bracket, removed it
yaronius
commented
Nov 12, 2021
|
|
||
| configuration := configuration.New( |
There was a problem hiding this comment.
renamed the var so that it doesn't shadow the package
|
|
||
| payload := bankid.SignPayload{PersonalNumber: "<INSERT PERSONAL NUMBER>", EndUserIp: "192.168.1.1", UserVisibleData: "Test"} |
There was a problem hiding this comment.
fixed the wrong case for payload property
|
|
||
| response, err := bankId.Sign(&payload) |
There was a problem hiding this comment.
we need context argument for this method
|
|
||
| fmt.Println(response.Collect()) |
There was a problem hiding this comment.
we need context argument for Collect() method too
|
|
||
| if err != nil { | ||
| if response := bankid.UnwrapErrorResponse(err); response != nil { |
There was a problem hiding this comment.
didn't find the UnwrapErrorResponse() function, but it works fine if try to cast it (tested)
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the code example in README is not working, updated it to be runnable. This closes #7