Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S09 unique bins #1465

Merged
merged 2 commits into from
Feb 15, 2025
Merged

S09 unique bins #1465

merged 2 commits into from
Feb 15, 2025

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Feb 15, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

see #1464

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

we only use one of the bins with the same MD5 sums. This does not really address the reported the race condition but it fixes the outcome in S09. In most of the other areas where we rely on P99_CSV we already did a head -1

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

As we did not fix the source of this bug we leave the original bug report open.

@m-1-k-3 m-1-k-3 added bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) labels Feb 15, 2025
@BenediktMKuehne BenediktMKuehne merged commit d15f4f5 into e-m-b-a:master Feb 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-1-k-3 @BenediktMKuehne