Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rk unsw end survey inapp browser #629

Merged
merged 7 commits into from
Mar 12, 2020

Conversation

atton16
Copy link
Contributor

@atton16 atton16 commented Mar 12, 2020

  • Add End Survey
  • Remove unwanted buttons in the settings page
    • Logout
    • Tracking
    • Medium Accuracy

Screenshots:
Screen Shot 2563-03-12 at 20 45 47
Screen Shot 2563-03-12 at 20 45 41

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@asiripanich
Copy link
Member

asiripanich commented Mar 12, 2020

@shankari We are removing the logout button to make sure our users won't accidentally logout which might cause confusion. We will advice them to delete the app once they fill the post-experience survey.

@asiripanich
Copy link
Member

@shankari Can you approve this as well?

const uuid = profile && profile.user_id && profile.user_id['$uuid'] ? profile.user_id['$uuid'] : 'undefined';
const fieldPath = '/aDHunALXzzHXAUMrvkvRT9/_user_id';
const returnURL = 'https://reward.amarin.dev';
$cordovaInAppBrowser.open(`https://ee.kobotoolbox.org/single/::T9bEosso?d[${fieldPath}]=${uuid}&returnURL=${returnURL}`, '_blank');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for the end survey you decided to just use the online kobotoolbox and not embed it into the app?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problems with this; just wanted to check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, due to the time constraint that we are facing.

@shankari shankari merged commit f5ccdf2 into e-mission:rk-unsw Mar 12, 2020
@asiripanich
Copy link
Member

@shankari press build? 😬

@shankari
Copy link
Contributor

wait, you want me to deploy this? I though you were only deploying to the rciti1, rciti2.... channels now

@shankari shankari mentioned this pull request Mar 12, 2020
@asiripanich
Copy link
Member

It is for testing. If works on rk-unsw then we gonna deploy to all other branches.

@shankari
Copy link
Contributor

ok gimme 10 mins

@asiripanich
Copy link
Member

Thank you :)

@shankari
Copy link
Contributor

deployed, should be live in ~10 mins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants