Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the mode inference pipeline to work with the new architecture #509

Merged
merged 39 commits into from
Feb 22, 2018

Conversation

shankari
Copy link
Contributor

Thanks to @jensteff for most of the actual porting
Design decisions tracked at https://github.com/e-mission/e-mission-server/issues/508

jensteff and others added 13 commits June 26, 2017 19:43
…erence

We need this to stay around so that we can seed our new pipeline with some data
until we have enough confirmed/corrected entries.

New test passes

```
$ ./e-mission-py.bash emission/tests/analysisTests/modeinferTests/TestPipelineSeed.py

----------------------------------------------------------------------
Ran 10 tests in 8.981s

OK
```
I am not sure why we were doing this, but it is certainly not used anywhere
now. And this is the obsolete pipeline, so it will never be used.
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/875/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/876/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/877/
Test FAILed.

We need to add a similar trip purpose wrapper
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/879/
Test FAILed.

With these fixes, the tests pass

Fixes are:
- indentation (tab versus space)
- remove extra merge marker
- remove mode_confirm object because the correct one is at
    `emission/core/wrapper/userlabel.py`, added as part of ee10c23
- change the setup of the pipeline test so that we
    - only delete newly added entries
    - copy database in the new way
- add jsonpickle to save the generated model
@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1001/
Test PASSed.

…e data

Since the analysis pipeline has already been defined, this was pretty easy.
And it is even tested.

Testing done: Ran it, there was a json file created.
To get rid of some of the warnings
@shankari
Copy link
Contributor Author

jenkins, test this please

so that we can change it without changing code + test options better
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1013/
Test FAILed.

Still unsure why this is not consistent given that they have the same seed, but
no time for debugging right now.
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1014/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1015/
Test FAILed.

Ground truth location change corresponding to
8d91eb7
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1016/
Test FAILed.

Ground truth distance change corresponding to
8d91eb7
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1017/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1018/
Test FAILed.

Ground truth location change corresponding to
8d91eb7
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1019/
Test FAILed.

…ersus local

Until I can see what is different and how best to fix it
@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/e-mission-server-prb/1020/
Test PASSed.

@shankari
Copy link
Contributor Author

Merging now to allow us to create static models and then use them for testing against the real data examples

@shankari shankari merged commit e524475 into e-mission:master Feb 22, 2018
valin1 pushed a commit to valin1/e-mission-server that referenced this pull request Oct 25, 2018
Get the mode inference pipeline to work with the new architecture
@shankari shankari mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants