Support fcm tokens for iOS phones as well #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the FCM plugin generates FCM tokens for both android and iOS. I don't like this on principle because it makes it harder to migrate to a different push service later. So we typically configure the app to generate APNS tokens and map on the server side. But that now requires editing GoogleServices.plist (FCM is the default) and it is easy to forget to do that. However, others may also not have this concern, and it does simplify the server side logic significantly to not have to do the mapping. So I now support FCM on both platforms, and add a config option to specify whether we are using APNS or FCM for iOS. If we are using FCM, we can skip the entire mapping logic
Otherwise the tests fail
I don't know why the test generates this file when we also copy it from `bin/deploy/push_conf.py` But not going to get into that complexity now.
- Pass in the `apns` token type in one more location - Add a new test for the FCM token type to ensure that the mapping shortcut works properly
jf87
pushed a commit
to jf87/e-mission-server
that referenced
this pull request
Jun 21, 2021
* Support fcm tokens for iOS phones as well By default, the FCM plugin generates FCM tokens for both android and iOS. I don't like this on principle because it makes it harder to migrate to a different push service later. So we typically configure the app to generate APNS tokens and map on the server side. But that now requires editing GoogleServices.plist (FCM is the default) and it is easy to forget to do that. However, others may also not have this concern, and it does simplify the server side logic significantly to not have to do the mapping. So I now support FCM on both platforms, and add a config option to specify whether we are using APNS or FCM for iOS. If we are using FCM, we can skip the entire mapping logic * Fix the default push configuration Otherwise the tests fail * Fix the sample push configuration in the tests as well I don't know why the test generates this file when we also copy it from `bin/deploy/push_conf.py` But not going to get into that complexity now. * Add a new test - Pass in the `apns` token type in one more location - Add a new test for the FCM token type to ensure that the mapping shortcut works properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the FCM plugin generates FCM tokens for both android and iOS.
I don't like this on principle because it makes it harder to migrate to a
different push service later.
So we typically configure the app to generate APNS tokens and map on the server
side. But that now requires editing GoogleServices.plist (FCM is the default)
and it is easy to forget to do that.
However, others may also not have this concern, and it does simplify the server
side logic significantly to not have to do the mapping.
So I now support FCM on both platforms, and add a config option to specify
whether we are using APNS or FCM for iOS.
If we are using FCM, we can skip the entire mapping logic