Server side changes to support infinite scroll #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ support querying by other time keys instead of only `metadata.write_ts`. This
ensures that we can accurately query for analysed results as well, since they
can be generated at any time after the raw data is collected.
+ support returning both the max and min value of any data field
- Change the existing call to get_max_value_for_field to use it
- Add a new method to the API that gets the pipeline range, not just the last entry
+ use this to figure out when to properly stop the infinite scroll
|
This partially fixes e-mission/e-mission-docs#226 |
This allows us to not go into an infinite scroll in case the user doesn't have any analysis results. Without this fix, we returned (-1, -1), so the phone code assumed that was valid and created the timestamp range by subtracting a week from it. So we kept going into negative timestamp ranges and got into an infinite loop. This returns None, so the `if (pipeline_range.end_ts)` check actually works
Which is now replaced by get_first_value_for_field(... pymongo.DESCENDING)
So we can check for 1c113c0 going forward
|
Related phone changes are at: |
jf87
pushed a commit
to jf87/e-mission-server
that referenced
this pull request
Jun 21, 2021
Server side changes to support infinite scroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadata.write_ts. Thisensures that we can accurately query for analysed results as well, since they
can be generated at any time after the raw data is collected.