New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that the mode label fields are prefixed by `label_` #844

Merged

shankari merged 1 commit into e-mission:master from shankari:fix_confirmed_trip_speed_call

Dec 15, 2021

Contributor

shankari commented Dec 11, 2021

So that the client can know that they are labels.
In the sensed mode labels, we use caps to distinguish them
https://github.com/e-mission/e-mission-phone/blob/42706f3f40423f91d02db443e011f45b8385505d/www/js/metrics.js#L826

Using a prefix allows us to distinguish between:

non-mode labels
sensed mode labels
labeled labels

fix tests to match


          Make sure that the mode label fields are prefixed by label_

ab82116

So that the client can know that they are labels.
In the sensed mode labels, we use caps to distinguish them
https://github.com/e-mission/e-mission-phone/blob/42706f3f40423f91d02db443e011f45b8385505d/www/js/metrics.js#L826

Using a prefix allows us to distinguish between:
- non-mode labels
- sensed mode labels
- labeled labels

+ fix tests to match

shankari merged commit 2081983 into e-mission:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet