Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change relative imports to absolute path #857

Closed
wants to merge 1 commit into from

Conversation

hlu109
Copy link
Contributor

@hlu109 hlu109 commented Jun 7, 2022

fix imports so that these python source files can be called from e-mission-eval-private-data or other repositories.

@shankari
Copy link
Contributor

shankari commented Jun 7, 2022

@hlu109 this is a good change, but unnecessary because we don't currently use any of the files in emission/analysis/modelling/tour_model. As part of a flurry of last minute refactoring, I pulled out the first round only into tour_model_first_only, and that is being further refactored #852

don't use the existing notebooks for the tour model; they will only confuse you and cause you to reinvent the wheel

Use e-mission/e-mission-eval-private-data#28 instead, where I already invented the wheel ?!

@shankari
Copy link
Contributor

shankari commented Jun 7, 2022

I might have some pending changes for that PR on my laptop; let me clean them up and submit them as well

@shankari
Copy link
Contributor

shankari commented Jun 7, 2022

Closed since I merged e-mission/e-mission-eval-private-data#28
But thanks for the PR!

@shankari shankari closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants