Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tendermint dependency #145

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Upgrade Tendermint dependency #145

merged 1 commit into from
Sep 22, 2021

Conversation

haasted
Copy link
Collaborator

@haasted haasted commented Sep 22, 2021

No description provided.

@haasted haasted merged commit a231d49 into master Sep 22, 2021
@haasted haasted deleted the 143-upgrade-TM branch September 22, 2021 11:04
@blewater
Copy link
Contributor

That's a cool upgrade.
My only observation is that Gaia and the Cosmos SDK pinned it with a replace clause, but looks like you set it successfully with a direct listing.

ref: https://github.com/cosmos/gaia/blob/06d6f8f29d989da7a5275e2a664d7ca7bf1992d8/go.mod#L23

@haasted
Copy link
Collaborator Author

haasted commented Sep 22, 2021

Well spotted!

The dependency above is the same version, though. Seems to me like the replace is a noop in this setup. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants