Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#112 - filter behaviour #126

Merged
merged 17 commits into from
Sep 1, 2023
Merged

#112 - filter behaviour #126

merged 17 commits into from
Sep 1, 2023

Conversation

vojcc
Copy link
Contributor

@vojcc vojcc commented Aug 22, 2023

This should:

close #41

image

close #42

image

close #59

image

close #89

image

close #95
Information for admin about errors after imports:

image

Also displayed in the navigation:

image

Admin can quickly search, create and delete city (or all cities):

image

close #97 and close #112

image

I also created page for single city where we can add information about prices, rules, opinions, notes etc.

image

@vojcc vojcc marked this pull request as ready for review August 31, 2023 22:59
@vojcc vojcc requested a review from a team as a code owner August 31, 2023 22:59
Copy link
Contributor

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why I have a lot of cities without coordinates?

image

  1. When I click "Cities with no country assigned" I see modal and when I click "Cities with no coordinates assigned" I'm on cities index page - we should unify this.

  2. So, I click "Cities with no country assigned" and see this:

image

And when I click the plus icon, I see modal for create city with the name of city, but I can't create city because the name is already exists - I think it will be better to redirect to edit city form.

3.1 It can be a good idea to change icon ❌ to 🗑️ icon just to be consistent, because everywhere we have trash icon when delete action is possible.

3.2 What is the function of "Delete all" button? As I see, the cities are not deleted, just warning about cities without country disappears. (and all providers?)

  1. When I click "Cities with no coordinates assigned" the counter of cities without coordinates and number of all results are not the same.

image

4.1 And why "Empty coordinates" option is in "Sort" dropdown? As I understand it's kind a filter for cities.

  1. When I click city, I see this: (why?)

image

  1. When I choose a country and there is no provider, this label "Providers" shoudn't be shown.

image

  1. When country has no provider, the dropdown with providers looks like this:

image

We can put some text like "There is no provider" or something. Second option is to block dropdown.

  1. When I click on provider dropdown, I select provider (obvious). When I click the second tme to the provider I deselect this (obvious). But when comes to country dropdown, it doesn't work like this. When I want to deselect country I can't, I have to clear filters.

  2. I'm not a big fan of changing filters on desktop - I think we should choose one type and stick to it. On mobile we can stick with dropdowns and on desktop like we have - I mean with this icons. Personally, I think that dropdowns on mobile and desktop will be okay.

  3. The filters with countries and providers don't have autocomplete.

  4. "Moje miasta" option should be visible only when user is logged into app.

@EwelinaSkrzypacz
Copy link
Contributor

After speaking with @vojcc we agreed couple of things:

  • Speaking of point 1 - I had old token. After using a new token, cities without
    assigned coordinates decreased. Fun fact: number of cities without countries has increased a bit.

image

  • point 2 - we agred that we should add title to modals.

  • point 3 - as this is a specific case, adding city instead of editing it should stay

  • point 3.2 - yea, it deletes cities

  • point 4 - after migrate fresh (again) and seed it works like it should

  • point 6 - after migrate fresh (again) and seed it works like it should

Now I'm wondering, why in edit city form we can't edit country?

@vojcc vojcc merged commit 0fb1eb9 into main Sep 1, 2023
@vojcc vojcc deleted the #112-filter-behaviour branch September 1, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants