-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#112 - filter behaviour #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why I have a lot of cities without coordinates?
-
When I click "Cities with no country assigned" I see modal and when I click "Cities with no coordinates assigned" I'm on cities index page - we should unify this.
-
So, I click "Cities with no country assigned" and see this:
And when I click the plus icon, I see modal for create city with the name of city, but I can't create city because the name is already exists - I think it will be better to redirect to edit city form.
3.1 It can be a good idea to change icon ❌ to 🗑️ icon just to be consistent, because everywhere we have trash icon when delete action is possible.
3.2 What is the function of "Delete all" button? As I see, the cities are not deleted, just warning about cities without country disappears. (and all providers?)
- When I click "Cities with no coordinates assigned" the counter of cities without coordinates and number of all results are not the same.
4.1 And why "Empty coordinates" option is in "Sort" dropdown? As I understand it's kind a filter for cities.
- When I click city, I see this: (why?)
- When I choose a country and there is no provider, this label "Providers" shoudn't be shown.
- When country has no provider, the dropdown with providers looks like this:
We can put some text like "There is no provider" or something. Second option is to block dropdown.
-
When I click on provider dropdown, I select provider (obvious). When I click the second tme to the provider I deselect this (obvious). But when comes to country dropdown, it doesn't work like this. When I want to deselect country I can't, I have to clear filters.
-
I'm not a big fan of changing filters on desktop - I think we should choose one type and stick to it. On mobile we can stick with dropdowns and on desktop like we have - I mean with this icons. Personally, I think that dropdowns on mobile and desktop will be okay.
-
The filters with countries and providers don't have autocomplete.
-
"Moje miasta" option should be visible only when user is logged into app.
After speaking with @vojcc we agreed couple of things:
Now I'm wondering, why in edit city form we can't edit country? |
This should:
close #41
close #42
close #59
close #89
close #95
Information for admin about errors after imports:
Also displayed in the navigation:
Admin can quickly search, create and delete city (or all cities):
close #97 and close #112
I also created page for single city where we can add information about prices, rules, opinions, notes etc.