#125 - alert confirm delete #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
1.For me this alert is too small. Something like https://tailwindui.com/components/application-ui/overlays/modals#component-47a5888a08838ad98779d50878d359b3 will be better.
- UX said, that we should avoid using useless words like "are you sure...". We can make something like for example:
When the user deletes the country, we can provide information, that the operation also removes cities.
- When I login into app, for a while I see login modal and after second or two it disappears. Can we make something with this?
simplescreenrecorder-2023-08-25_14.07.03.mp4
There was a problem hiding this comment.
- I think I will add information in the modal what is deleted - for me actual text is too general.
-
After successful login , the app freezers for a while :( - I upload a video about that in last comment.
-
The closing icon in right upper corner is missing.
-
Watch this video - modal doesn't want to show.
simplescreenrecorder-2023-08-25_15.10.09.mp4
EwelinaSkrzypacz
approved these changes
Aug 29, 2023
mtracz
reviewed
Aug 30, 2023
mtracz
reviewed
Aug 30, 2023
mtracz
approved these changes
Aug 31, 2023
vojcc
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added popup when admin is trying to delete city/country, also added toast notification when user login, logout and register, additionaly i changed way that toast notifications work. This should close #125