Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#142 - Add Hopp provider #171

Merged
merged 1 commit into from
Nov 30, 2023
Merged

#142 - Add Hopp provider #171

merged 1 commit into from
Nov 30, 2023

Conversation

JakubKermes
Copy link
Collaborator

@JakubKermes JakubKermes commented Nov 18, 2023 •
edited
Loading

This should close #142

@JakubKermes JakubKermes requested a review from a team as a code owner November 18, 2023 13:58
AleksandraKozubal
AleksandraKozubal reviewed Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@AleksandraKozubal AleksandraKozubal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The same thing happens here as in WheeMove, please add comment in #86 about it

@kamilpiech97
Copy link
Contributor

@JakubKermes please add description for your PR.

EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why I have 57 location on the list, but on admin home page (statistics) I see that I have only 54?

@EwelinaSkrzypacz
Copy link
Contributor

Why I have 57 location on the list, but on admin home page (statistics) I see that I have only 54?

As I observe, the problem occurs in almost all providers, co I think we should make separate issue for that. @JakubKermes can you verify that this problem occurs and if so, create the issue?

@JakubKermes
Copy link
Collaborator Author

@EwelinaSkrzypacz This issue occurs in almost all providers. Ryde shows 14 locations in the dashboard, but on the website, it has 25. Hulaj shows the correct number of 2 locations. Discrepancy seems to be present only in the dashboard, as there is the correct number of locations displayed on the map.

@JakubKermes JakubKermes merged commit db32a1b into main Nov 30, 2023
3 checks passed
@JakubKermes JakubKermes deleted the #142-add-hopp-provider branch November 30, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksandraKozubal AleksandraKozubal AleksandraKozubal approved these changes

@zmigrOO zmigrOO zmigrOO approved these changes

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Hopp provider
5 participants
@JakubKermes @kamilpiech97 @EwelinaSkrzypacz @zmigrOO @AleksandraKozubal