-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#90 - send e-mail when provider is added to or removed from favorite city #197
#90 - send e-mail when provider is added to or removed from favorite city #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Comments are unnecessary here.
- I don't receive e-mail, when new provider is added to favorite city
- In the codebase I see word "favorite" and "favourite" - we should unify that.
- I think that we can use here
Notification
- https://laravel.com/docs/10.x/notifications
example in toby: blumilksoftware/toby#54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still I don't get e-mail about added provider to the city.
My steps (I refreshed database and run fresh importers, just in case)
- Login into app.
- Add city to favorite (Brussels)
- Go to admin panel and add another provider for Brussels
- I expected mail, but there is not any :(
Co-authored-by: Kamil Piech <kamil.piech@blumilk.pl>
…-added-toremoved-from-favorite-city' into #90-send-e-mail-when-provider-is-added-toremoved-from-favorite-city
@EwelinaSkrzypacz, e-mail is sent while running importers. I thought manual changes should not notify user. Should I add that functionality? |
I think that it will be nice. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EwelinaSkrzypacz Hi, I cannot recreate your error. I get similar error message only when mailpit container is down. Could you check if you're running escooters-mailpit-dev container? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change in appearance happened during change from email to notification, I'll fix language issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The sentence "If you're having trouble clicking the "Dowiedz się więcej" button, copy and paste the URL below into your web browser: http://escooters.blumilk.localhost/" is not translated. And for link should redirected to the city, not to dashboard.
- The design of e-mails is still like default Laravel style. Will we update that?
Conflicts |
…oved-from-favorite-city
Still working on translation for the text in the bottom. I think we can leave it at default style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…oved-from-favorite-city
This should close #90