-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2 - main page #40
#2 - main page #40
Conversation
As in title.
As in title
As in title
As in title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will nit-pick a bit.
- When I run this project, I see some warning in console
-
For me on full HD, we shouldn't scroll to click buttons - they should be visible at the first glance.
-
We have two buttons in the same color - I think the button "TRY IT OUT" should be our CTA button, so it should have some color. But this "REGISTER" button could be outlined maybe? Also please add some padding to buttons. Buttons from TailwindUI are style quite good. Also for CTA button we need a little more stronger color, maybe sky-500? We can make components for CTA button like "PrimaryButton.vue" and for outline button "SecondaryButton" or something like this.
-
Please change UPPERCASE text on buttons to lowercase. We don't have to scream at the user.
-
This array next to "LOG IN" is small arrow
I'm not sure, if we need here an icon. But if we really want, we should use heroicons package https://heroicons.com/
First of all it's to much space between label and select. Also the label text doesn't have to really big. Next, we can rid of this "Select" text, because when the user sees select, he knows, that he should choose something, so we can stay with "Country" and "Provider".
- I think that here we need a little bit space
Also I think that I will swap country name and city name, because the flag is sufficient for most users, and they will care in which city are providers.
- I'm not a big fan of this scroll
Can we hide it?
-
As I understand, when the user chooses nothing from selects, he will see random six things. But when he chooses for example Poland as a country, will be here infinitive scroll or some pagination?
-
Can we add some minimalist footer? We could write there last version of page or something.
As in title.
As in title
|
As in title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in title.
As in title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should close #2 and close #14
As of now, most of the data is static just to show design and functionality of the components.Of course I am open to any suggestions regarding color scheme. There are some missing features, caused by the fact that most of the data needed in them is provided from backed, for example:
I will create issues regarding these changes.
Here are some screenshots of how it looks now on mobile and desktop.
Desktop main view:
Try it out/Logged user view:
Mobile main view:
Mobile Try it out/Logged user view:
Mobile Try it out/Logged user view after pressing map button:
Mobile Hamburger menu: