Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 - main page #40

Merged
merged 38 commits into from
Jul 5, 2023
Merged

#2 - main page #40

merged 38 commits into from
Jul 5, 2023

Conversation

brzozka
Copy link
Contributor

@brzozka brzozka commented Jun 22, 2023

This PR should close #2 and close #14

As of now, most of the data is static just to show design and functionality of the components.Of course I am open to any suggestions regarding color scheme. There are some missing features, caused by the fact that most of the data needed in them is provided from backed, for example:

  1. Clickable provider and country icons.
    Screenshot from 2023-06-22 10-18-21
  2. Similarly on mobile.
    Screenshot from 2023-06-22 10-17-47

I will create issues regarding these changes.
Here are some screenshots of how it looks now on mobile and desktop.

Desktop main view:
Screenshot from 2023-06-22 12-09-42

Try it out/Logged user view:
Screenshot from 2023-06-22 12-10-42

Mobile main view:
Screenshot from 2023-06-22 12-12-28

Mobile Try it out/Logged user view:
Screenshot from 2023-06-22 12-12-59

Mobile Try it out/Logged user view after pressing map button:
Screenshot from 2023-06-22 12-13-41

Mobile Hamburger menu:
Screenshot from 2023-06-22 12-14-52

@brzozka brzozka added feature new feature to implement javascript Pull requests that update Javascript code labels Jun 22, 2023
@brzozka brzozka requested a review from a team as a code owner June 22, 2023 10:23
@brzozka brzozka self-assigned this Jun 22, 2023
@brzozka brzozka changed the title #2 main page #2 - main page Jun 22, 2023
@brzozka brzozka requested review from mtracz and kamilpiech97 June 22, 2023 10:57
Copy link
Contributor

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will nit-pick a bit.

  1. When I run this project, I see some warning in console

image

  1. For me on full HD, we shouldn't scroll to click buttons - they should be visible at the first glance.

  2. We have two buttons in the same color - I think the button "TRY IT OUT" should be our CTA button, so it should have some color. But this "REGISTER" button could be outlined maybe? Also please add some padding to buttons. Buttons from TailwindUI are style quite good. Also for CTA button we need a little more stronger color, maybe sky-500? We can make components for CTA button like "PrimaryButton.vue" and for outline button "SecondaryButton" or something like this.

  3. Please change UPPERCASE text on buttons to lowercase. We don't have to scream at the user.

  4. This array next to "LOG IN" is small arrow

image

I'm not sure, if we need here an icon. But if we really want, we should use heroicons package https://heroicons.com/

image

First of all it's to much space between label and select. Also the label text doesn't have to really big. Next, we can rid of this "Select" text, because when the user sees select, he knows, that he should choose something, so we can stay with "Country" and "Provider".

  1. I think that here we need a little bit space

image

Also I think that I will swap country name and city name, because the flag is sufficient for most users, and they will care in which city are providers.

  1. I'm not a big fan of this scroll

image

Can we hide it?

  1. As I understand, when the user chooses nothing from selects, he will see random six things. But when he chooses for example Poland as a country, will be here infinitive scroll or some pagination?

  2. Can we add some minimalist footer? We could write there last version of page or something.

resources/js/Components/Panel.vue Outdated Show resolved Hide resolved
resources/js/Components/SearchList.vue Outdated Show resolved Hide resolved
resources/js/Components/SearchList.vue Outdated Show resolved Hide resolved
resources/js/Components/SearchPanel.vue Outdated Show resolved Hide resolved
resources/js/Components/SearchPanel.vue Outdated Show resolved Hide resolved
resources/js/Components/SearchPanel.vue Outdated Show resolved Hide resolved
resources/js/Components/Nav.vue Outdated Show resolved Hide resolved
resources/js/Components/Nav.vue Outdated Show resolved Hide resolved
@brzozka
Copy link
Contributor Author

brzozka commented Jun 26, 2023

  1. Fixed.
  2. I didn't encounter this error, even when I tried on different web browser, so I don't really know how to fix it.
  3. Fixed, the buttons are components now
  4. Fixed to lowercase.
  5. Deleted the arrow.
  6. Adjusted size and spacing.
  7. Names were swapped, and the select was removed.
  8. Scroll is now hidden in this element.
  9. As of now the scroll would be an infinitive scroll, I think user in country search should be able to type either country as a whole or a specific city.
  10. Added, I took it from one of blumilk's projects.

As in title.
@vojcc vojcc requested review from dawidrudnik and removed request for mtracz June 28, 2023 10:44
resources/css/app.css Outdated Show resolved Hide resolved
resources/js/Pages/Landing.vue Outdated Show resolved Hide resolved
resources/js/Shared/Components/Info.vue Outdated Show resolved Hide resolved
resources/js/Shared/Components/Panel.vue Outdated Show resolved Hide resolved
resources/js/Shared/Components/Panel.vue Outdated Show resolved Hide resolved
resources/js/Shared/Components/Panel.vue Outdated Show resolved Hide resolved
resources/js/Shared/Components/SearchList.vue Outdated Show resolved Hide resolved
resources/js/Shared/Components/SearchPanel.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I see warnings, when I run npm run dev

image

  1. On Chrome I see scroll on the main page

image

Maybe the image should be smaller? And it's a bit nit-picking, but I'm not a big fan of this buttons - for mobile they look different and for me better than in desktop.

brzozka added 2 commits June 28, 2023 15:17
As in title.
As in title.
Copy link
Contributor

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still I don't see buttons on main page:

image

resources/js/Shared/Layout/Nav.vue Outdated Show resolved Hide resolved
resources/js/Shared/Layout/Nav.vue Outdated Show resolved Hide resolved
resources/js/Shared/Layout/Footer.vue Outdated Show resolved Hide resolved
@brzozka
Copy link
Contributor Author

brzozka commented Jul 3, 2023

Still I don't see buttons on main page:

image

I don't know how to fix this problem, because I couldn't recreate it on both my laptop and pc. When I try the resolutions on inspect mode the whole page height is matching the given height fe. 1080.

@vojcc
Copy link
Contributor

vojcc commented Jul 4, 2023

image

image

image

image

image

resources/js/Shared/Components/Info.vue Outdated Show resolved Hide resolved
resources/js/Shared/Components/Info.vue Show resolved Hide resolved
resources/js/Shared/Components/Panel.vue Outdated Show resolved Hide resolved
resources/views/app.blade.php Outdated Show resolved Hide resolved
Copy link
Contributor

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these problems

image

@brzozka brzozka merged commit a1e8d52 into main Jul 5, 2023
@brzozka brzozka deleted the #2-main-page branch July 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature to implement javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design interface Main page
5 participants