[FEATURE] Resources: List of available languages for videos #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 46ab0ab.
☁️ Nx Cloud last updated this comment at |
FaithDaka
commented
Feb 4, 2025
| @@ -25,6 +25,8 @@ export interface IResourceBase_v0 { | |||
| priority?: number; | |||
| /** additional metadata populated for specific resource types */ | |||
| meta?: any; | |||
| /** Languages the resource is available in */ | |||
| languages?: string[]; | |||
There was a problem hiding this comment.
In order to accommodate the list of languages a resource video is available in, I added a languages array to the schema. Any comments on this? @chrismclarke
|
From the call
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Github Issue: #346
To list available languages for videos, a
selectdropdown has been implementedDiscussion
Videos currently lack language data to support this feature
Next Steps: Aggregate necessary data for the video
meta-dataPreview
Link to app preview if relevant
Screenshots