Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow anonymous feedback messages via settings #1704

Closed
janno42 opened this issue Feb 4, 2022 · 2 comments · Fixed by #1770
Closed

Allow anonymous feedback messages via settings #1704

janno42 opened this issue Feb 4, 2022 · 2 comments · Fixed by #1770
Assignees
Labels
[C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Major Major priority [S] Small This issue should require only small changes.
Milestone

Comments

@janno42
Copy link
Member

janno42 commented Feb 4, 2022

When sending a message in the feedback form, the sender field is currently automatically filled and disabled; thus users cannot give anonymous feedback.
This should be made optional via a new setting ALLOW_ANONYMOUS_FEEDBACK_MESSAGES. When set to FALSE, the current behavior is kept. When set to TRUE, a new checkbox is shown in the form, enabling users to send their message anonymously. Checking this checkbox will remove the sender information in the form and in the sent message's text.

@janno42 janno42 added [C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Major Major priority [S] Small This issue should require only small changes. labels Feb 4, 2022
@janno42 janno42 added this to the Summer 2022 milestone May 13, 2022
@richardebeling
Copy link
Member

@janno42 How much consideration went into the "checkbox" design already? The modal already has a disabled "Sender" field, I would have expected that this simply gets enabled and users get to choose between their name and "anonymous message"

@janno42
Copy link
Member Author

janno42 commented May 30, 2022

i initially thought of a checkbox that would remove the sender field like when deselecting "send message" on starting evaluations etc.
but using a button switch with the two options "send as " and " send anonymously" sounds good.

@janno42 janno42 modified the milestones: Summer 2022, Winter 2022 Aug 8, 2022
richardebeling pushed a commit that referenced this issue Aug 8, 2022
Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Major Major priority [S] Small This issue should require only small changes.
Development

Successfully merging a pull request may close this issue.

3 participants