Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make last saved counter less agressive #1752

Merged
merged 2 commits into from
May 9, 2022
Merged

Make last saved counter less agressive #1752

merged 2 commits into from
May 9, 2022

Conversation

jb3rndt
Copy link
Collaborator

@jb3rndt jb3rndt commented May 2, 2022

Solves #1741

richardebeling
richardebeling approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Thanks for fixing the semicolons!

evap/student/templates/student_vote.html Show resolved Hide resolved
janno42
janno42 approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Meets requirements
✔️ UI functionality checked

@janno42 janno42 force-pushed the last_saved_counter branch from 3f9bc03 to f63d02a Compare May 9, 2022 18:24
@janno42 janno42 merged commit fac7b41 into e-valuation:main May 9, 2022
@janno42
Copy link
Member

janno42 commented May 9, 2022

Thanks 🎆

@richardebeling richardebeling mentioned this pull request May 16, 2022
Closed
Kakadus pushed a commit to Kakadus/EvaP that referenced this pull request Jul 25, 2022
@jb3rndt
Make last saved counter less agressive (e-valuation#1752)
6de3120 
* Make last saved counter less agressive

* Remove useless default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janno42 janno42 janno42 approved these changes

@richardebeling richardebeling richardebeling approved these changes

@niklasmohrin niklasmohrin niklasmohrin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jb3rndt @janno42 @richardebeling @niklasmohrin