Remove django-sendfile2 and use the builtin FileResponse instead
#1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't even remember why we used `sendfile` in the first place, it claims to be optimized for sending large files and has specialized backends, but we only send smallish grade documents and use the "simple" backend anyways. Content type detection works with `FileResponse` too, so there really seems to be no reason to have the dependency anymore.
richardebeling
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1791
We don't even remember why we used
sendfilein the first place, it claims to be optimized for sending large files and has specialized backends, but we only send smallish grade documents and use the "simple" backend anyways. Content type detection works withFileResponsetoo, so there really seems to be no reason to have the dependency anymore.