Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port textanswer review quick view to TypeScript #1802

Merged
merged 32 commits into from
Sep 26, 2022
Merged

Port textanswer review quick view to TypeScript #1802

merged 32 commits into from
Sep 26, 2022

Conversation

niklasmohrin
Copy link
Member

Before working on the textanswer flagging, I wanted to get this done first.
This ports quick-review.js to TypeScript and replaces all uses of jQuery with standard DOM APIs.
I will also apply some refactorings and renames where I see fit.

@niklasmohrin
start porting
606bcc8
@niklasmohrin
port rest
5835259
@niklasmohrin
whoops
9516f3e
@niklasmohrin
cleaning
c0155a9
@niklasmohrin
prettier
c691d4a
@niklasmohrin
more cleanup, this, change html
6b7c52a
@niklasmohrin
layer numbering
80f5f2c
@niklasmohrin
fix activation of previous elements
93a6de5
@niklasmohrin
fix end slide having question above; better names
e4347fb
@niklasmohrin
fix sliding being too fast
a282c61
@niklasmohrin
whoops, I spilled my paint
a8c4e5f
@niklasmohrin
add startover button handlers
1c479d7
@niklasmohrin
fix right navigation buttons not showing up
103d7b9
@niklasmohrin
use more specific transition-property over just transition
b65ca1a
@niklasmohrin
not important
7f3d037
@niklasmohrin
important: working version
0cbe350
@niklasmohrin
enum Action; inline review_action
87b36e1
@niklasmohrin
dont submit if assertions fail
46de2ca
@niklasmohrin
clean up the paint I spilled the other day
333c0ff
@niklasmohrin
extract function updateAlertSlide
cab0fe5
@niklasmohrin
add very helpful comment for future
6d2aa62
@niklasmohrin
fix typo for skip-evaluation selector, dont use jquery extension sele…
5bdc8b1 
…ctor, update answer_id inputs even when on last slide
@niklasmohrin
the types lied to me
649254f
@niklasmohrin
rename updateForm to form
8bccd73
@niklasmohrin
actually, lets not use URL, it cannot be relative
6a4379e
@niklasmohrin
rename things
73be0a5
@niklasmohrin
add reminder
2262bec
@niklasmohrin niklasmohrin marked this pull request as ready for review September 12, 2022 15:27
janno42
janno42 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ UI functionality checked

evap/static/ts/src/quick-review-slider.ts Outdated Show resolved Hide resolved
richardebeling
richardebeling reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks mostly good (but I was very distracted during review, so I might have missed a lot)

evap/static/ts/src/quick-review-slider.ts Outdated Show resolved Hide resolved
evap/static/ts/src/quick-review-slider.ts Outdated Show resolved Hide resolved
richardebeling
richardebeling approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI seems to work reliably

evap/staff/templates/quick-review.js Outdated Show resolved Hide resolved
@niklasmohrin niklasmohrin merged commit 7833da1 into e-valuation:main Sep 26, 2022
@niklasmohrin niklasmohrin deleted the quick-rewrite branch September 26, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 janno42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasmohrin @janno42 @richardebeling