Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1813: Refactor error messages for rewards #1832

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Fix for #1813: Refactor error messages for rewards #1832

merged 6 commits into from
Dec 5, 2022

Conversation

florian-str
Copy link
Collaborator

This fixes #1813.

richardebeling
richardebeling requested changes Nov 13, 2022
View reviewed changes
evap/rewards/views.py Outdated Show resolved Hide resolved
evap/rewards/views.py Outdated Show resolved Hide resolved
evap/rewards/views.py Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! One nit: we can remove the one line that sets error_string to its initial value; this will also make Python complain if we ever catch another kind of error but forget to set error_string

evap/rewards/views.py Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin requested changes Nov 21, 2022
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for #1832 (comment), looks good other than that

@niklasmohrin niklasmohrin requested a review from janno42 November 28, 2022 17:59
@janno42 janno42 merged commit 60328bd into e-valuation:main Dec 5, 2022
@janno42
Copy link
Member

janno42 commented Dec 5, 2022

Thank you 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 janno42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate error messages and error detection in reward points redemption
4 participants
@florian-str @janno42 @richardebeling @niklasmohrin