Http verbs #1837
Http verbs #1837
Conversation
|
If you want to try at home: The branch is not based on the current version of our ... or we do it together at the next meeting :) |
florian-str
force-pushed
the
http_verbs
branch
from
bf5f19a to
3d20866
Compare
florian-str
force-pushed
the
http_verbs
branch
from
3d20866 to
789a39c
Compare
evap/rewards/views.py
Outdated
|
|
||
| return semester_view(request=request, semester_id=semester_id) | ||
| messages.get_messages(request).used = False | ||
| return redirect("staff:semester_view", semester_id) # semester_view(request=request, semester_id=semester_id) |
There was a problem hiding this comment.
| return redirect("staff:semester_view", semester_id) # semester_view(request=request, semester_id=semester_id) | |
| return redirect("staff:semester_view", semester_id) |
evap/rewards/views.py
Outdated
| SemesterActivation.objects.update_or_create(semester=semester, defaults={"is_active": active}) | ||
| if active: | ||
| grant_eligible_reward_points_for_semester(request, semester) | ||
|
|
||
| return semester_view(request=request, semester_id=semester_id) | ||
| messages.get_messages(request).used = False |
There was a problem hiding this comment.
Is this necessary / what does it do? I think we've used redirects before and everything worked fine with messages.
|
|
||
| {{ block.super }} | ||
| <form id="form_activation_status" method="post" action="{% url 'rewards:semester_activation_edit' semester.id%}"> |
There was a problem hiding this comment.
| <form id="form_activation_status" method="post" action="{% url 'rewards:semester_activation_edit' semester.id%}"> | |
| <form id="form_activation_status" method="post" action="{% url 'rewards:semester_activation_edit' semester.id %}"> |
|
|
||
| {{ block.super }} | ||
| <form id="form_activation_status" method="post" action="{% url 'rewards:semester_activation_edit' semester.id%}"> | ||
| <input type="hidden" id="activation_status" name="activation_status" value="on"> {# FIXME #} |
There was a problem hiding this comment.
I'd oppose having a fixme without any comment here. I would be (hesitantly) okay with a reference to an issue (FIXME #123456). Overall, I'm just in favor of adding the issue and not adding the fixme. TODOs in code have a tendency to stay there.
@niklasmohrin what do you think? (Follow-up to #1837 (comment))
(repeated below in the javascript)
There was a problem hiding this comment.
No strong opinion, we can make an issue if you want
|
Thanks for submitting the PR :) |
It changes the HTTP-Endpoint for a semester activation.
Due to the nature of the confirmation modals, only the query directly effected was changed to a form.