Importer improvements #1855
Merged
Importer improvements #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
force-pushed
the
import-improvements
branch
2 times, most recently
from
4a971b7 to
e2c2884
Compare
|
@niklasmohrin mypy and the invalid-value-is-a-type approach actually caught an error here that tests did not cover and we might have missed: In the checker, I first forgot to ignore rows where parsing the degree had failed (-> InvalidValue). The tests that went this path never checked whether any unexpected errors occured, so they passed because their expected error on degree parsing existed, and they simply ignored the unexpected error. I've made the tests more assertive regarding unexpected errors in the last commit. Removing the branch in the checker now also causes a few tests to fail. |
richardebeling
commented
Jan 29, 2023
niklasmohrin
reviewed
Feb 6, 2023
janno42
approved these changes
Feb 13, 2023
niklasmohrin
approved these changes
Feb 14, 2023
richardebeling
force-pushed
the
import-improvements
branch
from
b601e69 to
ec17aa7
Compare
richardebeling
force-pushed
the
import-improvements
branch
from
ec17aa7 to
5eb5086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1574. Best served by commit.